[
https://issues.apache.org/jira/browse/BEAM-10991?focusedWorklogId=493740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493740
]
ASF GitHub Bot logged work on BEAM-10991:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/20 23:42
Start Date: 01/Oct/20 23:42
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12993:
URL: https://github.com/apache/beam/pull/12993#issuecomment-702448732
# [Codecov](https://codecov.io/gh/apache/beam/pull/12993?src=pr&el=h1) Report
> Merging
[#12993](https://codecov.io/gh/apache/beam/pull/12993?src=pr&el=desc) into
[release-2.25.0](https://codecov.io/gh/apache/beam/commit/741dbadecdaa27f4624e97de54f488b802af11f2?el=desc)
will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12993?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.25.0 #12993 +/- ##
===============================================
Coverage 82.30% 82.31%
===============================================
Files 455 455
Lines 54589 54589
===============================================
+ Hits 44931 44935 +4
+ Misses 9658 9654 -4
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12993?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12993/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
| `80.26% <0.00%> (-0.45%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12993/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `88.80% <0.00%> (-0.18%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12993/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `94.31% <0.00%> (-0.14%)` | :arrow_down: |
|
[...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12993/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==)
| `80.75% <0.00%> (+0.17%)` | :arrow_up: |
|
[sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/12993/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5)
| `95.63% <0.00%> (+0.18%)` | :arrow_up: |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12993/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `89.20% <0.00%> (+0.44%)` | :arrow_up: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/12993/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `89.90% <0.00%> (+1.22%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12993?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12993?src=pr&el=footer). Last
update
[c329565...2696d62](https://codecov.io/gh/apache/beam/pull/12993?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493740)
Time Spent: 1h 40m (was: 1.5h)
> Timers don't release watermark holds in dataflow on 2.24
> --------------------------------------------------------
>
> Key: BEAM-10991
> URL: https://issues.apache.org/jira/browse/BEAM-10991
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.24.0
> Reporter: Steve Niemitz
> Assignee: Kenneth Knowles
> Priority: P1
> Fix For: 2.25.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We have multiple streaming pipelines (using state + timers) that, after
> upgrading to 2.24, exhibited very strange watermark behavior. The watermark
> on some stateful DoFns would advance to the end of the first window, and then
> get stuck there forever, even preventing the job from draining.
> I was able to track the problem down to
> [https://github.com/apache/beam/commit/88acc5267f759d81e9836a9db17b9e0ee521c785.|https://github.com/apache/beam/commit/88acc5267f759d81e9836a9db17b9e0ee521c785]
> After revering it, the behavior went back to normal. It looks like its
> possible in that commit that watermark holds for some timers aren't being
> cleared.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
