[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=493746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493746
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/20 00:15
Start Date: 02/Oct/20 00:15
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #12883:
URL: https://github.com/apache/beam/pull/12883#discussion_r498569928
##########
File path: sdks/python/apache_beam/metrics/metric.py
##########
@@ -101,23 +121,26 @@ def gauge(namespace, name):
class DelegatingCounter(Counter):
"""Metrics Counter that Delegates functionality to MetricsEnvironment."""
def __init__(self, metric_name):
+ # type: (MetricName) -> None
super(Metrics.DelegatingCounter, self).__init__()
self.metric_name = metric_name
- self.inc = MetricUpdater(cells.CounterCell, metric_name, default=1)
+ self.inc = MetricUpdater(cells.CounterCell, metric_name, default=1) #
type: ignore[assignment]
Review comment:
Yes, please go ahead and ignore this error. (Note also that this code is
structured in this way for performance reasons; previously we had pipelines
where the bulk of the CPU was spent in generic counter update code, whereas
here MetricUpdater is as fast as possible for incrementing an int).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493746)
Time Spent: 105h (was: 104h 50m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 105h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
