[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=190005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190005
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/19 13:47
Start Date: 25/Jan/19 13:47
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7597: [WIP] [BEAM-5442]
Retrieve valid runner options from JobService
URL: https://github.com/apache/beam/pull/7597#discussion_r250986670
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -733,33 +710,6 @@ def _add_argparse_args(cls, parser):
'command.'))
-class FlinkOptions(PipelineOptions):
-
- @classmethod
- def _add_argparse_args(cls, parser):
- parser.add_argument('--flink_master',
- type=str,
- help=
- ('Address of the Flink master where the pipeline '
- 'should be executed. Can either be of the form '
- '\'host:port\' or one of the special values '
- '[local], [collection], or [auto].'))
Review comment:
Do we want to replace this with a stub or something similar? Would be
helpful to know that FlinkOptions are loaded from the runner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 190005)
Time Spent: 18h (was: 17h 50m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 18h
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
