[
https://issues.apache.org/jira/browse/BEAM-7?focusedWorklogId=494154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-494154
]
ASF GitHub Bot logged work on BEAM-7:
-------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/20 21:24
Start Date: 02/Oct/20 21:24
Worklog Time Spent: 10m
Work Description: chadrik commented on a change in pull request #13004:
URL: https://github.com/apache/beam/pull/13004#discussion_r499056525
##########
File path: sdks/python/apache_beam/transforms/userstate.py
##########
@@ -305,23 +323,37 @@ def validate_stateful_dofn(dofn):
(timer_spec, method_name, dofn))
-class RuntimeTimer(object):
+class BaseTimer(object):
Review comment:
I added a base class so that I could have a return type for
`UserStateContext.get_timer()`. Also see `bundle_processor. OutputTimer` (at
the top of the PR).
An alternative to this would be to create a `Protocol`, but that seemed
needlessly complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 494154)
Time Spent: 50m (was: 40m)
> Import Dataflow code
> --------------------
>
> Key: BEAM-7
> URL: https://issues.apache.org/jira/browse/BEAM-7
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-gcp, runner-core, runner-dataflow,
> runner-direct, sdk-java-core
> Reporter: Frances Perry
> Assignee: Davor Bonaci
> Priority: P2
> Fix For: 0.1.0-incubating
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
