[
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=495449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495449
]
ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/20 16:54
Start Date: 05/Oct/20 16:54
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #13006:
URL: https://github.com/apache/beam/pull/13006#discussion_r499739492
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ReadTranslator.java
##########
@@ -54,9 +54,9 @@ public void translate(
final PCollection<T> output = ctx.getOutput(transform);
final Coder<WindowedValue<T>> coder = SamzaCoders.of(output);
final Source<?> source =
- transform instanceof Read.Unbounded
- ? ((Read.Unbounded) transform).getSource()
- : ((Read.Bounded) transform).getSource();
+ transform instanceof SplittableParDo.PrimitiveBoundedRead
Review comment:
When debugging locally I can see that the PAssert executes once and gets
the correct input and then it executes another time only containing
`"finished"` (coming from the finishBundle on the TestFn) which implies that
the PAssert trigger is occurring multiple times causing the verifier to fail on
a subsequent bundle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 495449)
Time Spent: 23h 50m (was: 23h 40m)
> Make non-portable Splittable DoFn the only option when executing Java "Read"
> transforms
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10670
> URL: https://issues.apache.org/jira/browse/BEAM-10670
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 23h 50m
> Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for
> non-portable execution except for Dataflow runner v1 which will internalize
> the current primitive read implementation that is shared across runner
> implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
