[
https://issues.apache.org/jira/browse/BEAM-10991?focusedWorklogId=495601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495601
]
ASF GitHub Bot logged work on BEAM-10991:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/20 21:49
Start Date: 05/Oct/20 21:49
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#12993:
URL: https://github.com/apache/beam/pull/12993#discussion_r499891415
##########
File path: CHANGES.md
##########
@@ -131,6 +132,9 @@
--temp_location, or pass method="STREAMING_INSERTS" to WriteToBigQuery
([BEAM-6928](https://issues.apache.org/jira/browse/BEAM-6928)).
* Python SDK now understands `typing.FrozenSet` type hints, which are not
interchangeable with `typing.Set`. You may need to update your pipelines if
type checking fails.
([BEAM-10197](https://issues.apache.org/jira/browse/BEAM-10197))
+## Known issues
+
+* When a timer fires but is reset prior to being executed, a watermark hold
may be leaked, causing a stuck pipeline
[BEAM-10991](https://issues.apache.org/jira/browse/BEAM-10991).
Review comment:
Thorough review! Actually I did a pure revert in #12980 so I reverted
that line from `CHANGES.md`. Then in #12997 I added it back. If you "view file"
at this commit you will see it is there, because on the release branch it was
not accidentally reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 495601)
Time Spent: 3h 40m (was: 3.5h)
> Timers don't release watermark holds in dataflow on 2.24
> --------------------------------------------------------
>
> Key: BEAM-10991
> URL: https://issues.apache.org/jira/browse/BEAM-10991
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Affects Versions: 2.24.0
> Reporter: Steve Niemitz
> Assignee: Kenneth Knowles
> Priority: P1
> Fix For: 2.25.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> We have multiple streaming pipelines (using state + timers) that, after
> upgrading to 2.24, exhibited very strange watermark behavior. The watermark
> on some stateful DoFns would advance to the end of the first window, and then
> get stuck there forever, even preventing the job from draining.
> I was able to track the problem down to
> [https://github.com/apache/beam/commit/88acc5267f759d81e9836a9db17b9e0ee521c785.|https://github.com/apache/beam/commit/88acc5267f759d81e9836a9db17b9e0ee521c785]
> After revering it, the behavior went back to normal. It looks like its
> possible in that commit that watermark holds for some timers aren't being
> cleared.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
