[
https://issues.apache.org/jira/browse/BEAM-11019?focusedWorklogId=495646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-495646
]
ASF GitHub Bot logged work on BEAM-11019:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 00:15
Start Date: 06/Oct/20 00:15
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #13013:
URL: https://github.com/apache/beam/pull/13013#discussion_r499939012
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -134,40 +134,40 @@ func (n *ParDo) processMainInput(mainIn *MainInput) error
{
// If the function observes windows, we must invoke it for each window.
The expected fast path
// is that either there is a single window or the function doesn't
observes windows.
Review comment:
Consider amending the comment here making the optimization explicit.
...doesn't observe windows meaning they can be computed simultaneously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 495646)
Time Spent: 0.5h (was: 20m)
> Adjust Go SDF progress reporting to account for multi-window elements.
> ----------------------------------------------------------------------
>
> Key: BEAM-11019
> URL: https://issues.apache.org/jira/browse/BEAM-11019
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> SDF progress reporting should account for exploded windows. For example, if
> an element being processed is in three windows, and those windows get
> exploded, then it essentially is being processed 3 times. So after the first
> window's done, progress should be at 1/3, then at 2/3 after the second, and
> so on. Instead, at the moment progress is only reported for the current
> element which means it'll constantly loop from 0 -> 1.0 over and over as the
> element gets processed in each window.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
