[
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=496053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496053
]
ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 17:37
Start Date: 06/Oct/20 17:37
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #12603:
URL: https://github.com/apache/beam/pull/12603#issuecomment-704435983
> I see, so it is the full switch from Read.Bounded/Unbounded to SDF by
default. Can you get this one green so we can test it and then merge it, I
would like to see if there is some perf impact, and probably that we document
how to get the previous `Unbounded` translation in case any existing users find
any difference.
>
> If I understood correctly you might intend to tackle watermark holds in
the 'future'? Just for learning curiosity I assume this will be done in
`SparkProcessKeyedElements` for Gbk/Stateful translation, might this need some
extra changes? asking just because I am reading the translation of Portable
Streaming runner and I see watermarks are taken into account from Impulse so I
was wondering if something was missing here or if this is done in a different
place maybe in core.
I'll be going on paternity soon so I'll try to see what I can get working
with the GlobalWatermarkHolder implementation that exists. I think we should be
able to use arbitrary ids in it it just might be really slow since the
readers/writers should really care about their upstream watermarks (main and
side input) so having a global broadcast seems less then desirable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 496053)
Time Spent: 28h 20m (was: 28h 10m)
> Make non-portable Splittable DoFn the only option when executing Java "Read"
> transforms
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10670
> URL: https://issues.apache.org/jira/browse/BEAM-10670
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 28h 20m
> Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for
> non-portable execution except for Dataflow runner v1 which will internalize
> the current primitive read implementation that is shared across runner
> implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
