[ 
https://issues.apache.org/jira/browse/BEAM-11025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209037#comment-17209037
 ] 

Ning Kang commented on BEAM-11025:
----------------------------------

Based on the standard output, it looks like the None is returned by one of the 
failure paths when the environment is considered not in a notebook.

There could be a race condition when tests are running in parallel and 
modifying the global instance ib.current_env().
In that case, a patch in the test to use a mocked `is_in_notebook` check should 
be added.

> PCollectionVisualizationTest.test_dynamic_plotting_return_handle failing in 
> precommit
> -------------------------------------------------------------------------------------
>
>                 Key: BEAM-11025
>                 URL: https://issues.apache.org/jira/browse/BEAM-11025
>             Project: Beam
>          Issue Type: Test
>          Components: runner-py-interactive
>            Reporter: Ning Kang
>            Assignee: Ning Kang
>            Priority: P2
>
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Phrase/2241/testReport/junit/apache_beam.runners.interactive.display.pcoll_visualization_test/PCollectionVisualizationTest/test_dynamic_plotting_return_handle/
> Error Message
> AssertionError: None is not an instance of <class 'timeloop.app.Timeloop'>
> Stacktrace
> self = 
> <apache_beam.runners.interactive.display.pcoll_visualization_test.PCollectionVisualizationTest
>  testMethod=test_dynamic_plotting_return_handle>
>     def test_dynamic_plotting_return_handle(self):
>       h = pv.visualize(
>           self._stream, dynamic_plotting_interval=1, display_facets=True)
> >     self.assertIsInstance(h, timeloop.Timeloop)
> E     AssertionError: None is not an instance of <class 
> 'timeloop.app.Timeloop'>
> apache_beam/runners/interactive/display/pcoll_visualization_test.py:93: 
> AssertionError
> Standard Output
> <IPython.core.display.HTML object>
> <IPython.core.display.HTML object>
>    0
> 0  0
> 1  1
> 2  2
> 3  3
> 4  4



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to