[
https://issues.apache.org/jira/browse/BEAM-10720?focusedWorklogId=497493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497493
]
ASF GitHub Bot logged work on BEAM-10720:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/20 18:26
Start Date: 08/Oct/20 18:26
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12705:
URL: https://github.com/apache/beam/pull/12705#discussion_r501926434
##########
File path: sdks/python/apache_beam/dataframe/transforms_test.py
##########
@@ -266,6 +266,17 @@ def check(actual):
lambda x: {'res': 3 * x}, proxy)
assert_that(res['res'], equal_to_series(three_series), 'CheckDictOut')
+ def test_cat(self):
+ # verify that cat works with a List[Series] sicne this is missing from
doctests
+ df = pd.DataFrame({
+ 'one': ['A', 'B', 'C'],
+ 'two': ['BB', 'CC', 'A'],
+ 'three': ['CCC', 'AA', 'B'],
+ })
+ self.run_scenario(df, lambda df: df.two.str.cat([df.three], join='outer'))
+ self.run_scenario(
+ df, lambda df: df.one.str.cat([df.two, df.three], join='outer'))
+
Review comment:
Thank you!
In order to avoid refactoring the elementwise methods I made
DeferredStringMethods store two expressions, one that accesses Series.str, and
one for the underlying Series. This seems to get things passing, but I'm not
100% sure this is safe. I'll look at extending `elementwise_method` for this
use-case instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 497493)
Time Spent: 7h 20m (was: 7h 10m)
> Implement pandas StringMethods
> ------------------------------
>
> Key: BEAM-10720
> URL: https://issues.apache.org/jira/browse/BEAM-10720
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Priority: P2
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> We need to add stubs for pd.Series.str:
> https://pandas.pydata.org/pandas-docs/version/0.25/reference/series.html#string-handling
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
