[ 
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=497588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497588
 ]

ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/20 20:57
            Start Date: 08/Oct/20 20:57
    Worklog Time Spent: 10m 
      Work Description: iemejia edited a comment on pull request #13021:
URL: https://github.com/apache/beam/pull/13021#issuecomment-705812846


   Yes definitely!
   
   For the watermark part of my comment what I was expecting is that because we 
now need to [deal with WatermarkEstimator + 
ProcessContinuation](https://github.com/apache/beam/blob/163579bbc962c3f3c6f1996fd4294f016f1c13ff/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDoNaiveBounded.java#L168)
 (even if dummy versions) for the SDF case it would maybe impact a bit the 
performance (+ the Restrictions moving around).
   
   I am still unclear about why partitioning is better. From what I understood 
the Source is splitting in subsources that are the restrictions and from there 
we reshuffle, I expected similar results. So any extra detail would be nice to 
see what am I missing.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 497588)
    Time Spent: 36h 20m  (was: 36h 10m)

> Make non-portable Splittable DoFn the only option when executing Java "Read" 
> transforms
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-10670
>                 URL: https://issues.apache.org/jira/browse/BEAM-10670
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: P2
>          Time Spent: 36h 20m
>  Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for 
> non-portable execution except for Dataflow runner v1 which will internalize 
> the current primitive read implementation that is shared across runner 
> implementations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to