[
https://issues.apache.org/jira/browse/BEAM-11033?focusedWorklogId=497686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497686
]
ASF GitHub Bot logged work on BEAM-11033:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/20 00:56
Start Date: 09/Oct/20 00:56
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #13024:
URL: https://github.com/apache/beam/pull/13024#issuecomment-705900291
# [Codecov](https://codecov.io/gh/apache/beam/pull/13024?src=pr&el=h1) Report
> Merging
[#13024](https://codecov.io/gh/apache/beam/pull/13024?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/826dd726846a47970802b6bfc07fdb11491fe81f?el=desc)
will **increase** coverage by `0.00%`.
> The diff coverage is `79.37%`.
[](https://codecov.io/gh/apache/beam/pull/13024?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13024 +/- ##
=======================================
Coverage 82.49% 82.49%
=======================================
Files 455 455
Lines 54867 54890 +23
=======================================
+ Hits 45264 45283 +19
- Misses 9603 9607 +4
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/13024?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...les/complete/juliaset/juliaset/juliaset\_test\_it.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29tcGxldGUvanVsaWFzZXQvanVsaWFzZXQvanVsaWFzZXRfdGVzdF9pdC5weQ==)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/utils/timestamp.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdGltZXN0YW1wLnB5)
| `95.43% <ø> (ø)` | |
|
[sdks/python/apache\_beam/utils/windowed\_value.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvd2luZG93ZWRfdmFsdWUucHk=)
| `92.54% <ø> (ø)` | |
|
[...dks/python/apache\_beam/metrics/monitoring\_infos.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9tb25pdG9yaW5nX2luZm9zLnB5)
| `96.64% <50.00%> (ø)` | |
|
[sdks/python/apache\_beam/metrics/cells.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9jZWxscy5weQ==)
| `80.73% <53.84%> (ø)` | |
|
[...n/apache\_beam/runners/dataflow/dataflow\_metrics.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19tZXRyaWNzLnB5)
| `75.94% <62.50%> (+1.62%)` | :arrow_up: |
|
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
| `79.40% <69.23%> (ø)` | |
|
[sdks/python/apache\_beam/metrics/execution.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWV0cmljcy9leGVjdXRpb24ucHk=)
| `87.40% <73.91%> (ø)` | |
|
[...s/python/apache\_beam/runners/worker/log\_handler.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvbG9nX2hhbmRsZXIucHk=)
| `87.71% <83.33%> (ø)` | |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `89.63% <86.11%> (+0.31%)` | :arrow_up: |
| ... and [56
more](https://codecov.io/gh/apache/beam/pull/13024/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/13024?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/13024?src=pr&el=footer). Last
update
[52ef994...0875aed](https://codecov.io/gh/apache/beam/pull/13024?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 497686)
Time Spent: 50m (was: 40m)
> Update Dataflow metrics processor to handle portable jobs
> ---------------------------------------------------------
>
> Key: BEAM-11033
> URL: https://issues.apache.org/jira/browse/BEAM-11033
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, Dataflow metrics processor expects Dataflow internal step names
> generated for v1beta3 job description in metrics returned by Dataflow
> service:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py#L97]
>
> But with portable job submission, Dataflow uses PTransform ID (in proto
> pipeline) as the internal step name. Hence metrics processor should be
> updated to handle this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
