[ 
https://issues.apache.org/jira/browse/BEAM-11047?focusedWorklogId=498611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-498611
 ]

ASF GitHub Bot logged work on BEAM-11047:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Oct/20 15:14
            Start Date: 09/Oct/20 15:14
    Worklog Time Spent: 10m 
      Work Description: jobegrabber commented on pull request #13058:
URL: https://github.com/apache/beam/pull/13058#issuecomment-706240299


   Thanks for the fast response, @kmjung!
   Okay, I understand the reasoning - I did wonder why no one in 4 years 
complained, but since I haven't worked with BigQuery's legacy JSON API I did 
not think of this being an issue.
   
   Then this PR and issue can be closed, but I see a good case for a follow-up 
ticket to improve documentation both in code and on the website :smile: 
   I'll have a look and try to come up with a PR for that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 498611)
    Time Spent: 50m  (was: 40m)

> BigQuery IO: Avro INTEGER values get converted to String objects
> ----------------------------------------------------------------
>
>                 Key: BEAM-11047
>                 URL: https://issues.apache.org/jira/browse/BEAM-11047
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.22.0, 2.23.0, 2.24.0
>            Reporter: Jonas Grabber
>            Priority: P2
>              Labels: bigquery, java
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> For some reason, convertRequiredField used in 
> BigQueryAvroUtils.convertGenericRecordToTableRow [casts values with the Avro 
> INTEGER type to Long, but then converts them to String objects via 
> toString|https://github.com/apache/beam/blob/v2.23.0/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryAvroUtils.java#L326].
> I'm quite unsure where convertGenericRecordToTableRow is used elsewhere, but 
> we use it to utilize BigQuery's Storage API reads.
> I'm fairly certain this is not expected behaviour because other types are 
> converted properly and due to the cast to Long it's ensured that any values 
> will fit into Long objects anyways.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to