[
https://issues.apache.org/jira/browse/BEAM-11052?focusedWorklogId=498783&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-498783
]
ASF GitHub Bot logged work on BEAM-11052:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/20 23:04
Start Date: 09/Oct/20 23:04
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13066:
URL: https://github.com/apache/beam/pull/13066#discussion_r502706227
##########
File path: sdks/python/apache_beam/dataframe/convert.py
##########
@@ -67,6 +68,9 @@ def to_dataframe(
expressions.PlaceholderExpression(proxy, pcoll))
+TO_PCOLLECTION_CACHE = {}
Review comment:
Note this uses a global cache which can be problematic in testing. I
don't think we need to worry about pcollections being shared across pipelines
though since the dataframe expressions should have a reference to the pipeline
through the to_dataframe roots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 498783)
Time Spent: 20m (was: 10m)
> to_pcollection should memoize on DF expressions
> -----------------------------------------------
>
> Key: BEAM-11052
> URL: https://issues.apache.org/jira/browse/BEAM-11052
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should always return the same PCollection when `to_pcollection` is called
> multiple times with the same input, this will allow for better integration
> with interactive notebooks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
