[
https://issues.apache.org/jira/browse/BEAM-4776?focusedWorklogId=190744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190744
]
ASF GitHub Bot logged work on BEAM-4776:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 04:10
Start Date: 28/Jan/19 04:10
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7621:
[BEAM-4776] make AutoValues for MetricResults, MetricQueryResults
URL: https://github.com/apache/beam/pull/7621#discussion_r251278585
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricQueryResults.java
##########
@@ -17,20 +17,29 @@
*/
package org.apache.beam.sdk.metrics;
+import com.google.auto.value.AutoValue;
import org.apache.beam.sdk.annotations.Experimental;
import org.apache.beam.sdk.annotations.Experimental.Kind;
/**
* The results of a query for metrics. Allows accessing all of the metrics
that matched the filter.
*/
+@AutoValue
@Experimental(Kind.METRICS)
-public interface MetricQueryResults {
- /** Return the metric results for the counters that matched the filter. */
- Iterable<MetricResult<Long>> getCounters();
+public abstract class MetricQueryResults {
+ /** Return the metric results for the getCounters that matched the filter. */
Review comment:
just noticed this `getCounters` comment typo (and similar below); I put a
fix here in #7641 for now:
https://github.com/apache/beam/pull/7641/commits/6a21a6bac2fe7e95afc345687961f8ef287b3042
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 190744)
Time Spent: 0.5h (was: 20m)
> Java PortableRunner should support metrics
> ------------------------------------------
>
> Key: BEAM-4776
> URL: https://issues.apache.org/jira/browse/BEAM-4776
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> BEAM-4775 concerns adding metrics to the JobService API; the current issue is
> about making PortableRunner understand them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
