[ 
https://issues.apache.org/jira/browse/BEAM-6518?focusedWorklogId=190880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190880
 ]

ASF GitHub Bot logged work on BEAM-6518:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Jan/19 10:32
            Start Date: 28/Jan/19 10:32
    Worklog Time Spent: 10m 
      Work Description: mxm commented on issue #7638: [BEAM-6518] fix python 
metric-querying bug
URL: https://github.com/apache/beam/pull/7638#issuecomment-458076643
 
 
   Could you please give a quick example of why this needs to be fixed?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 190880)
    Time Spent: 20m  (was: 10m)

> Substring-matching bug in Python metrics filtering
> --------------------------------------------------
>
>                 Key: BEAM-6518
>                 URL: https://issues.apache.org/jira/browse/BEAM-6518
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>    Affects Versions: 2.9.0
>            Reporter: Ryan Williams
>            Assignee: Ryan Williams
>            Priority: Trivial
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{[MetricResults._matches_sub_path|https://github.com/apache/beam/blob/5b46b02b49ca1c5c18682427a5a4a25596ca4287/sdks/python/apache_beam/metrics/metric.py#L152-L163]}}
>  can be fooled into a false-negative if a path component before the one it is 
> looking for is a superstring of the one it's looking for.
> It's not particularly likely to happen, but worth fixing anyway.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to