[
https://issues.apache.org/jira/browse/BEAM-3736?focusedWorklogId=499443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499443
]
ASF GitHub Bot logged work on BEAM-3736:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/20 14:53
Start Date: 12/Oct/20 14:53
Worklog Time Spent: 10m
Work Description: kamilwu commented on a change in pull request #13048:
URL: https://github.com/apache/beam/pull/13048#discussion_r503350536
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -875,18 +875,20 @@ class CombineFn(WithTypeHints, HasDisplayData,
urns.RunnerApiFn):
input argument, which is an instance of CombineFnProcessContext). The
combining process proceeds as follows:
- 1. Input values are partitioned into one or more batches.
- 2. For each batch, the create_accumulator method is invoked to create a fresh
+ 1. The setup method is invoked.
Review comment:
It probably should be like this:
```
1. Input values are partitioned into one or more batches.
2. For each batch, the setup method is invoked.
3. For each batch, the create_accumulator method is invoked...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 499443)
Time Spent: 4.5h (was: 4h 20m)
> Add SetUp() and TearDown() for CombineFns
> -----------------------------------------
>
> Key: BEAM-3736
> URL: https://issues.apache.org/jira/browse/BEAM-3736
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-py-core
> Reporter: Chuan Yu Foo
> Assignee: Kamil Wasilewski
> Priority: P3
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> I have a CombineFn that has a large amount of state that needs to be loaded
> once before it can add_input or merge_combiners (for example, the CombineFn
> might load up a large lookup table used for combining).
> Right now, to initialise this state, for each of the methods, I check if the
> state has already been initialised, and if not, I initialise it. It would be
> nice if CombineFn provided a SetUp() method that is called once to initialise
> this state (and a corresponding TearDown() method to clean up this state if
> necessary).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
