[
https://issues.apache.org/jira/browse/BEAM-11020?focusedWorklogId=499698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499698
]
ASF GitHub Bot logged work on BEAM-11020:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/20 22:42
Start Date: 12/Oct/20 22:42
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #13070:
URL: https://github.com/apache/beam/pull/13070#discussion_r503569540
##########
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##########
@@ -354,12 +354,12 @@ func (n *DataSource) Split(splits []int64, frac float64,
bufSize int64) (SplitRe
return SplitResult{PI: s - 1, RI: s}, nil
}
// Otherwise, perform a sub-element split.
- p, r, err := su.Split(fr)
+ ps, rs, err := su.Split(fr)
if err != nil {
return SplitResult{}, err
}
- if p == nil || r == nil { // Unsuccessful split.
+ if len(ps) == 0 || len(rs) == 0 { // Unsuccessful split.
Review comment:
Idiomatically, if there's no intended semantic real difference between
nil and empty, then checking the length is the correct way to handle that. nil
slices are also 0 length.
This catches the error case that empty slices are generated, and hints to
the compiler that there's at least 1 entry in the slices after this if block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 499698)
Time Spent: 1h 40m (was: 1.5h)
> Fix multi-window SDF splitting in Go.
> -------------------------------------
>
> Key: BEAM-11020
> URL: https://issues.apache.org/jira/browse/BEAM-11020
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When splitting an element that's being processed on multiple windows,
> currently the element gets split based on the current progress of the current
> element+window pair, and the primary and residual both contain all windows
> from the original. This is incorrect as certain windows in the residual have
> already been processed.
> The correct way to perform this split is to put the element + all fully
> processed windows in the primary, the element + all fully unprocessed windows
> in the residual, and then only split the element at the current element +
> window pair.
> This fix should already be in Java and Python, so those can be referenced.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
