[
https://issues.apache.org/jira/browse/BEAM-11056?focusedWorklogId=499756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499756
]
ASF GitHub Bot logged work on BEAM-11056:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Oct/20 00:55
Start Date: 13/Oct/20 00:55
Worklog Time Spent: 10m
Work Description: davidyan74 commented on a change in pull request #13080:
URL: https://github.com/apache/beam/pull/13080#discussion_r503608190
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -52,98 +53,116 @@
class Options(interactive_options.InteractiveOptions):
"""Options that guide how Interactive Beam works."""
@property
- def enable_capture_replay(self):
- """Whether replayable source data capture should be replayed for multiple
- PCollection evaluations and pipeline runs as long as the data captured is
+ def enable_record_replay(self):
Review comment:
enable_recording_replay. Basically, if "capture" is used as a noun,
change it to "recording" instead of "record", since "record" used as a noun
usually means an individual record instead of the act of recording. Please
check all occurrences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 499756)
Time Spent: 1h 10m (was: 1h)
> Fix warning message and rename old APIs
> ---------------------------------------
>
> Key: BEAM-11056
> URL: https://issues.apache.org/jira/browse/BEAM-11056
> Project: Beam
> Issue Type: Bug
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When invoking `ib.evict_captured_data()`, the logging contains a typo
> `recordeddata`:
> `You have requested Interactive Beam to evict all recordeddata that could be
> deterministically replayed among multiple pipeline runs.`
> Also, the `capture_control` should be renamed to `record_control`. All
> occurrences of `capture` should be changed to `record` to keep the
> consistency of large source recording improvements.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
