[ 
https://issues.apache.org/jira/browse/BEAM-10009?focusedWorklogId=500183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500183
 ]

ASF GitHub Bot logged work on BEAM-10009:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Oct/20 17:10
            Start Date: 13/Oct/20 17:10
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #12921:
URL: https://github.com/apache/beam/pull/12921#discussion_r504122208



##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -928,7 +928,13 @@ message StandardCoders {
     //     values.
     //   - For present values the null indicator is followed by the value
     //     encoded with it's corresponding coder.
-    //
+    // 
+    // Well known logical types:
+    //   beam:logical_type:micros_instant:v1
+    //   - Representation type: ROW<seconds: INT64, micros: INT64>
+    //   - A timezone naive timestamp where seconds + micros represents the

Review comment:
       ```suggestion
       //   - A timestamp without a timezone where seconds + micros represents 
the
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 500183)
    Time Spent: 7h  (was: 6h 50m)

> Support for date times in Python schemas
> ----------------------------------------
>
>                 Key: BEAM-10009
>                 URL: https://issues.apache.org/jira/browse/BEAM-10009
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Priority: P3
>          Time Spent: 7h
>  Remaining Estimate: 0h
>
> When DATETIME is converted to a MillisInstant logical type, add support for 
> it to RowCoder and python schemas.
> Probably we should map MillisInstant to datetime with  
> [datetime.datetime.from_timestamp|https://docs.python.org/3/library/datetime.html#datetime.datetime.fromtimestamp]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to