[
https://issues.apache.org/jira/browse/BEAM-6494?focusedWorklogId=190972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190972
]
ASF GitHub Bot logged work on BEAM-6494:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 13:36
Start Date: 28/Jan/19 13:36
Worklog Time Spent: 10m
Work Description: epithatree commented on pull request #7645: [BEAM-6494]
Fixes bug in RedisIO
URL: https://github.com/apache/beam/pull/7645
When we have prepared a transaction to be executed on the Redis server, we
now push that transaction to the server. Previously the buffer was only flushed
when the pipeline was closed.
@jbonofre
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 190972)
Time Spent: 10m
Remaining Estimate: 0h
> We do not sync pipeline with server at bundle end, only during teardown
> -----------------------------------------------------------------------
>
> Key: BEAM-6494
> URL: https://issues.apache.org/jira/browse/BEAM-6494
> Project: Beam
> Issue Type: Bug
> Components: io-java-redis
> Affects Versions: 2.9.0
> Reporter: Robert Collins
> Assignee: Robert Collins
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The redis pipeline object only sends executed commands to the redis server
> when sync() or close() are called. If these are not called, the calls stay
> inside the buffer. As teardown is not guaranteed to be called, we should call
> pipeline.sync() inside finishBundle, after pipeline.exec().
> [docs|https://beam.apache.org/releases/javadoc/2.5.0/org/apache/beam/sdk/transforms/DoFn.Teardown.html]
>
> @FinishBundle
> public void finishBundle() {
> if (pipeline.isInMulti()) {
> pipeline.exec();
> }
> batchCount = 0;
> }
> @Teardown
> public void teardown() {
> jedis.close();
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
