[ 
https://issues.apache.org/jira/browse/BEAM-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216653#comment-17216653
 ] 

Tomasz Szerszen commented on BEAM-11026:
----------------------------------------

If I understand this issue correctly maven coords mean: 
{{groupId:artifactId:version.}}

Code below uses shadowJar plugin, which hides version and dependency.
{code:java}
def default_io_expansion_service():
  return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
{code}
Should we abandon shadowing and do something like code below?
{code:java}
def default_io_expansion_service(): 
  return 
BeamJarExpansionService('org.apache.beam:beam-sdks-java-io-expansion-service:2.24.0')
{code}
which will be using maven coords as stated in the issue.

> When determining expansion service jar, depend on Maven coords instead of 
> Gradle target
> ---------------------------------------------------------------------------------------
>
>                 Key: BEAM-11026
>                 URL: https://issues.apache.org/jira/browse/BEAM-11026
>             Project: Beam
>          Issue Type: Improvement
>          Components: cross-language, sdk-py-core
>            Reporter: Chamikara Madhusanka Jayalath
>            Priority: P2
>
> For example here: 
> https://github.com/apache/beam/blob/release-2.24.0/sdks/python/apache_beam/io/kafka.py#L107
> Maven coords is more stable than the Gradle target name so it's better to 
> depend on the prior. See [1] for details.
> [1] https://issues.apache.org/jira/browse/BEAM-10986
>  
> cc: [~robertwb] [~bhulette] [~kenn]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to