[ 
https://issues.apache.org/jira/browse/BEAM-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216866#comment-17216866
 ] 

Michael Luckey edited comment on BEAM-11068 at 10/19/20, 4:28 PM:
------------------------------------------------------------------

Afaict, the implementation is a (slightly adapted) copy of the 
[project|https://github.com/googleapis/gax-java/tree/master/gax-bom] referenced 
[here|https://jlbp.dev/JLBP-15.html]

I do not know, whether there have been other consideration apart from, that 
works. 

Regarding java platform plugin: it just did not exist at the time of 
implementation (iirc). We might consider switching to that, but we probably 
should discuss whether we also want to switch our dependency enforcing code to 
that. And of course, as we need a quick fix to unblock release, I did not care 
to suggest that.


was (Author: michel):
Afaict, the implementation is a (slightly adapted) copy of the 
[project|https://github.com/googleapis/gax-java/tree/master/gax-bom] referenced 
[here|https://jlbp.dev/JLBP-15.html]

I do not know, whether there have been other consideration apart from, that 
works. 

> beam-sdks-java-bom.pom cannot be signed after upgrade to Gradle 6
> -----------------------------------------------------------------
>
>                 Key: BEAM-11068
>                 URL: https://issues.apache.org/jira/browse/BEAM-11068
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Robin Qiu
>            Assignee: Kenneth Knowles
>            Priority: P1
>             Fix For: 2.26.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I am working on creating Beam 2.25.0 RC1. The repo I created 
> (https://repository.apache.org/#stagingRepositories) failed to close because:
> Missing Signature: 
> '/org/apache/beam/beam-sdks-java-bom/2.25.0/beam-sdks-java-bom-2.25.0.pom.asc'
>  does not exist for 'beam-sdks-java-bom-2.25.0.pom'.
> I checked pom files in other modules and their signatures are present, so I 
> think this problem only happens to beam-sdks-java-bom-2.25.0.pom. Also this 
> has not happened in previous releases. I suspect this is caused by the recent 
> upgrade to Gradle 6.
> I found that 
> https://github.com/apache/beam/blob/master/sdks/java/bom/build.gradle does 
> something special. It does not use a generated pom, instead it uses its own 
> template and copies that to sdks/java/bom/build/publications/mavenJava/ as 
> pom-default.xml. When I run the publish task locally, I found in 
> sdks/java/bom/build/publications/mavenJava/ that the pom-default.xml is 
> signed (i.e. pom-default.xml.asc is present), but 
> beam-sdks-java-bom-2.25.0.pom is not signed (i.e. 
> beam-sdks-java-bom-2.25.0.pom.asc is not present) in the output repository.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to