[
https://issues.apache.org/jira/browse/BEAM-10940?focusedWorklogId=503298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-503298
]
ASF GitHub Bot logged work on BEAM-10940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/20 16:48
Start Date: 21/Oct/20 16:48
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #13120:
URL: https://github.com/apache/beam/pull/13120#discussion_r509441928
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/ProcessBundleDescriptorsTest.java
##########
@@ -151,6 +157,99 @@ public void onTimer() {}
ensureLengthPrefixed(timerKeyCoder, originalKeyCoder, pbsCoderMap);
}
+ @Test
+ public void testLengthPrefixingOfInputCoderExecutableStage() throws
Exception {
+ Pipeline p = Pipeline.create();
+ Coder<Void> voidCoder = VoidCoder.of();
+ assertThat(ModelCoderRegistrar.isKnownCoder(voidCoder), is(false));
+ p.apply("impulse", Impulse.create())
+ .apply(
+ ParDo.of(
+ new DoFn<byte[], Void>() {
+ @ProcessElement
+ public void process(ProcessContext ctxt) {}
+ }))
+ .setCoder(voidCoder)
+ .apply(
+ ParDo.of(
+ new DoFn<Void, Void>() {
+ @ProcessElement
+ public void processElement(
+ ProcessContext context, RestrictionTracker<Void, Void>
tracker) {}
+
+ @GetInitialRestriction
+ public Void getInitialRestriction() {
+ return null;
+ }
+
+ @NewTracker
+ public SomeTracker newTracker(@Restriction Void restriction)
{
+ return null;
+ }
+ }))
+ .setCoder(voidCoder);
+ RunnerApi.Pipeline pipelineProto = PipelineTranslation.toProto(p);
+ RunnerApi.Pipeline pipelineWithSdfExpanded =
+ ProtoOverrides.updateTransform(
+ PTransformTranslation.PAR_DO_TRANSFORM_URN,
+ pipelineProto,
+ SplittableParDoExpander.createSizedReplacement());
+ FusedPipeline fused = GreedyPipelineFuser.fuse(pipelineWithSdfExpanded);
+ Optional<ExecutableStage> optionalStage =
+ Iterables.tryFind(
+ fused.getFusedStages(),
+ (ExecutableStage stage) ->
+ stage.getTransforms().stream()
+ .anyMatch(
+ transform ->
+ transform
+ .getTransform()
+ .getSpec()
+ .getUrn()
+ .equals(
+ PTransformTranslation
+
.SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN)));
+ checkState(
+ optionalStage.isPresent(),
+ "Expected a stage with
SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN.");
+
+ ExecutableStage stage = optionalStage.get();
+ PipelineNode.PCollectionNode inputPCollection =
stage.getInputPCollection();
+ Map<String, RunnerApi.Coder> stageCoderMap =
stage.getComponents().getCodersMap();
+ RunnerApi.Coder originalMainInputCoder =
+ stageCoderMap.get(inputPCollection.getPCollection().getCoderId());
+
+ BeamFnApi.ProcessBundleDescriptor pbd =
+ ProcessBundleDescriptors.fromExecutableStage(
+ "test_stage", stage,
Endpoints.ApiServiceDescriptor.getDefaultInstance())
+ .getProcessBundleDescriptor();
+ Map<String, RunnerApi.Coder> pbsCoderMap = pbd.getCodersMap();
+
+ RunnerApi.Coder pbsMainInputCoder =
+
pbsCoderMap.get(pbd.getPcollectionsOrThrow(inputPCollection.getId()).getCoderId());
+
+ RunnerApi.Coder kvCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(pbsMainInputCoder).keyCoderId());
+ RunnerApi.Coder elementCoder =
Review comment:
```suggestion
RunnerApi.Coder keyCoder =
```
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/ProcessBundleDescriptorsTest.java
##########
@@ -151,6 +157,99 @@ public void onTimer() {}
ensureLengthPrefixed(timerKeyCoder, originalKeyCoder, pbsCoderMap);
}
+ @Test
+ public void testLengthPrefixingOfInputCoderExecutableStage() throws
Exception {
+ Pipeline p = Pipeline.create();
+ Coder<Void> voidCoder = VoidCoder.of();
+ assertThat(ModelCoderRegistrar.isKnownCoder(voidCoder), is(false));
+ p.apply("impulse", Impulse.create())
+ .apply(
+ ParDo.of(
+ new DoFn<byte[], Void>() {
+ @ProcessElement
+ public void process(ProcessContext ctxt) {}
+ }))
+ .setCoder(voidCoder)
+ .apply(
+ ParDo.of(
+ new DoFn<Void, Void>() {
+ @ProcessElement
+ public void processElement(
+ ProcessContext context, RestrictionTracker<Void, Void>
tracker) {}
+
+ @GetInitialRestriction
+ public Void getInitialRestriction() {
+ return null;
+ }
+
+ @NewTracker
+ public SomeTracker newTracker(@Restriction Void restriction)
{
+ return null;
+ }
+ }))
+ .setCoder(voidCoder);
+ RunnerApi.Pipeline pipelineProto = PipelineTranslation.toProto(p);
+ RunnerApi.Pipeline pipelineWithSdfExpanded =
+ ProtoOverrides.updateTransform(
+ PTransformTranslation.PAR_DO_TRANSFORM_URN,
+ pipelineProto,
+ SplittableParDoExpander.createSizedReplacement());
+ FusedPipeline fused = GreedyPipelineFuser.fuse(pipelineWithSdfExpanded);
+ Optional<ExecutableStage> optionalStage =
+ Iterables.tryFind(
+ fused.getFusedStages(),
+ (ExecutableStage stage) ->
+ stage.getTransforms().stream()
+ .anyMatch(
+ transform ->
+ transform
+ .getTransform()
+ .getSpec()
+ .getUrn()
+ .equals(
+ PTransformTranslation
+
.SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN)));
+ checkState(
+ optionalStage.isPresent(),
+ "Expected a stage with
SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN.");
+
+ ExecutableStage stage = optionalStage.get();
+ PipelineNode.PCollectionNode inputPCollection =
stage.getInputPCollection();
+ Map<String, RunnerApi.Coder> stageCoderMap =
stage.getComponents().getCodersMap();
+ RunnerApi.Coder originalMainInputCoder =
+ stageCoderMap.get(inputPCollection.getPCollection().getCoderId());
+
+ BeamFnApi.ProcessBundleDescriptor pbd =
+ ProcessBundleDescriptors.fromExecutableStage(
+ "test_stage", stage,
Endpoints.ApiServiceDescriptor.getDefaultInstance())
+ .getProcessBundleDescriptor();
+ Map<String, RunnerApi.Coder> pbsCoderMap = pbd.getCodersMap();
+
+ RunnerApi.Coder pbsMainInputCoder =
+
pbsCoderMap.get(pbd.getPcollectionsOrThrow(inputPCollection.getId()).getCoderId());
+
+ RunnerApi.Coder kvCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(pbsMainInputCoder).keyCoderId());
+ RunnerApi.Coder elementCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(kvCoder).keyCoderId());
+ RunnerApi.Coder valueKvCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(kvCoder).valueCoderId());
+ RunnerApi.Coder valueCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(valueKvCoder).keyCoderId());
+
+ RunnerApi.Coder originalKvCoder =
+
stageCoderMap.get(ModelCoders.getKvCoderComponents(originalMainInputCoder).keyCoderId());
+ RunnerApi.Coder originalElementCoder =
Review comment:
```suggestion
RunnerApi.Coder originalKeyCoder =
```
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/ProcessBundleDescriptorsTest.java
##########
@@ -151,6 +157,99 @@ public void onTimer() {}
ensureLengthPrefixed(timerKeyCoder, originalKeyCoder, pbsCoderMap);
}
+ @Test
+ public void testLengthPrefixingOfInputCoderExecutableStage() throws
Exception {
+ Pipeline p = Pipeline.create();
+ Coder<Void> voidCoder = VoidCoder.of();
+ assertThat(ModelCoderRegistrar.isKnownCoder(voidCoder), is(false));
+ p.apply("impulse", Impulse.create())
+ .apply(
+ ParDo.of(
+ new DoFn<byte[], Void>() {
+ @ProcessElement
+ public void process(ProcessContext ctxt) {}
+ }))
+ .setCoder(voidCoder)
+ .apply(
+ ParDo.of(
+ new DoFn<Void, Void>() {
+ @ProcessElement
+ public void processElement(
+ ProcessContext context, RestrictionTracker<Void, Void>
tracker) {}
+
+ @GetInitialRestriction
+ public Void getInitialRestriction() {
+ return null;
+ }
+
+ @NewTracker
+ public SomeTracker newTracker(@Restriction Void restriction)
{
+ return null;
+ }
+ }))
+ .setCoder(voidCoder);
+ RunnerApi.Pipeline pipelineProto = PipelineTranslation.toProto(p);
+ RunnerApi.Pipeline pipelineWithSdfExpanded =
+ ProtoOverrides.updateTransform(
+ PTransformTranslation.PAR_DO_TRANSFORM_URN,
+ pipelineProto,
+ SplittableParDoExpander.createSizedReplacement());
+ FusedPipeline fused = GreedyPipelineFuser.fuse(pipelineWithSdfExpanded);
+ Optional<ExecutableStage> optionalStage =
+ Iterables.tryFind(
+ fused.getFusedStages(),
+ (ExecutableStage stage) ->
+ stage.getTransforms().stream()
+ .anyMatch(
+ transform ->
+ transform
+ .getTransform()
+ .getSpec()
+ .getUrn()
+ .equals(
+ PTransformTranslation
+
.SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN)));
+ checkState(
+ optionalStage.isPresent(),
+ "Expected a stage with
SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN.");
+
+ ExecutableStage stage = optionalStage.get();
+ PipelineNode.PCollectionNode inputPCollection =
stage.getInputPCollection();
+ Map<String, RunnerApi.Coder> stageCoderMap =
stage.getComponents().getCodersMap();
+ RunnerApi.Coder originalMainInputCoder =
+ stageCoderMap.get(inputPCollection.getPCollection().getCoderId());
+
+ BeamFnApi.ProcessBundleDescriptor pbd =
+ ProcessBundleDescriptors.fromExecutableStage(
+ "test_stage", stage,
Endpoints.ApiServiceDescriptor.getDefaultInstance())
+ .getProcessBundleDescriptor();
+ Map<String, RunnerApi.Coder> pbsCoderMap = pbd.getCodersMap();
+
+ RunnerApi.Coder pbsMainInputCoder =
+
pbsCoderMap.get(pbd.getPcollectionsOrThrow(inputPCollection.getId()).getCoderId());
+
+ RunnerApi.Coder kvCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(pbsMainInputCoder).keyCoderId());
+ RunnerApi.Coder elementCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(kvCoder).keyCoderId());
+ RunnerApi.Coder valueKvCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(kvCoder).valueCoderId());
+ RunnerApi.Coder valueCoder =
+
pbsCoderMap.get(ModelCoders.getKvCoderComponents(valueKvCoder).keyCoderId());
+
+ RunnerApi.Coder originalKvCoder =
+
stageCoderMap.get(ModelCoders.getKvCoderComponents(originalMainInputCoder).keyCoderId());
+ RunnerApi.Coder originalElementCoder =
+
stageCoderMap.get(ModelCoders.getKvCoderComponents(originalKvCoder).keyCoderId());
+ RunnerApi.Coder originalvalueKvCoder =
+
stageCoderMap.get(ModelCoders.getKvCoderComponents(originalKvCoder).valueCoderId());
+ RunnerApi.Coder originalvalueCoder =
+
stageCoderMap.get(ModelCoders.getKvCoderComponents(originalvalueKvCoder).keyCoderId());
+
+ ensureLengthPrefixed(elementCoder, originalElementCoder, pbsCoderMap);
Review comment:
```suggestion
ensureLengthPrefixed(keyCoder, originalKeyCoder, pbsCoderMap);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 503298)
Time Spent: 1h 50m (was: 1h 40m)
> Portable Flink runner should handle DelayedBundleApplication from
> ProcessBundleResponse.
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-10940
> URL: https://issues.apache.org/jira/browse/BEAM-10940
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Boyuan Zhang
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> SDF can produce residuals by self-checkpoint, which will be returned to
> runner by ProcessBundleResponse.DelayedBundleApplication. The portable runner
> should be able to handle the DelayedBundleApplication and reschedule it based
> on the timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
