[
https://issues.apache.org/jira/browse/BEAM-5313?focusedWorklogId=191134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191134
]
ASF GitHub Bot logged work on BEAM-5313:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 17:10
Start Date: 28/Jan/19 17:10
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on pull request #7583:
[BEAM-5313] Python 3 port examples package
URL: https://github.com/apache/beam/pull/7583#discussion_r251508662
##########
File path: sdks/python/apache_beam/examples/complete/tfidf_test.py
##########
@@ -85,8 +85,8 @@ def test_basics(self):
with open_shards(os.path.join(
temp_folder, 'result-*-of-*')) as result_file:
for line in result_file:
- match = re.search(EXPECTED_LINE_RE, line)
- logging.info('Result line: %s', line)
+ match = re.search(EXPECTED_LINE_RE, line.decode('utf-8'))
Review comment:
Sounds good, but I think we need to set `encoding='utf-8'` as a default
argument on open_shards, since the default encoding used by `io.open()` is
platform dependent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191134)
Time Spent: 2h 10m (was: 2h)
> Finish Python 3 porting for examples module
> -------------------------------------------
>
> Key: BEAM-5313
> URL: https://issues.apache.org/jira/browse/BEAM-5313
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
