[
https://issues.apache.org/jira/browse/BEAM-10402?focusedWorklogId=504329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504329
]
ASF GitHub Bot logged work on BEAM-10402:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/20 21:23
Start Date: 23/Oct/20 21:23
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13134:
URL: https://github.com/apache/beam/pull/13134#discussion_r511161466
##########
File path: sdks/java/extensions/protobuf/build.gradle
##########
@@ -18,8 +18,13 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature(
- enableChecker: false,
ignoreRawtypeErrors: true,
+ generatedClassPatterns: [
+
'^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto2CoderTestMessages',
+
'^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto2SchemaMessages',
+
'^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto3SchemaMessages',
+ '^org\\.apache\\.beam\\.sdk\\.extensions\\.protobuf\\.Proto3SchemaOptions',
Review comment:
Nice! I was unaware of them before, but did a check to see if there was
some kind of regex literal we could use. I guess `~"pattern"` is an option as
well, but produces `Pattern` instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 504329)
Time Spent: 6h 10m (was: 6h)
> [Umbrella] Eliminate nullability errors from Beam Java
> ------------------------------------------------------
>
> Key: BEAM-10402
> URL: https://issues.apache.org/jira/browse/BEAM-10402
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: P1
> Labels: Clarified, starter
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> I enabled the checker framework and the core SDK exceeds 100 nullability
> errors immediately. We should make this number zero, since nullability errors
> are solved problem in computer science and they do periodically impact Beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
