[
https://issues.apache.org/jira/browse/BEAM-6513?focusedWorklogId=191190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191190
]
ASF GitHub Bot logged work on BEAM-6513:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 18:29
Start Date: 28/Jan/19 18:29
Worklog Time Spent: 10m
Work Description: akedin commented on pull request #7636: [BEAM-6513] Fix
NPE in BeamEnumerableConverter
URL: https://github.com/apache/beam/pull/7636#discussion_r251536507
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
##########
@@ -368,3 +387,7 @@ public void visitValue(PValue value, Node producer) {
return visitor.boundedness == IsBounded.UNBOUNDED;
}
}
+
+class ClassForNull {
Review comment:
I think this approach is probably much less clear than manual
synchronization. Reading the code to handle `ClassForNull` I have to understand
all of the logic in multiple classes plus know the behavior of
`ConcurrentLinkedQueue` and question our choice to use it in the first place.
If it was a single `synchronized addToValues()` with a comment, it would be
much clearer what is happening and why, and it would be a single place to look
at. How much extra complexity we are adding vs benefits of using
`ConcurrentLinkedQueue`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191190)
Time Spent: 1h (was: 50m)
> BeamEnumerableConverter doest not handle Null during collecting values
> ----------------------------------------------------------------------
>
> Key: BEAM-6513
> URL: https://issues.apache.org/jira/browse/BEAM-6513
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
