[
https://issues.apache.org/jira/browse/BEAM-6520?focusedWorklogId=191249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191249
]
ASF GitHub Bot logged work on BEAM-6520:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 20:29
Start Date: 28/Jan/19 20:29
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7648: [BEAM-6520]
Deprecate MongoDb `withKeepAlive`
URL: https://github.com/apache/beam/pull/7648#discussion_r251580621
##########
File path:
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java
##########
@@ -133,6 +133,10 @@ private MongoDbIO() {}
@Nullable
abstract String uri();
+ /**
+ * @deprecated This is deprecated in the MongoDB API and will be removed
in a future version.
Review comment:
Ok, updated the comment referring default and not disable recommendation.
However did that for the `withKeepAlive` method since it is the 'public' API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191249)
Time Spent: 1h 50m (was: 1h 40m)
> Deprecate MongoDb `withKeepAlive` because it is deprecated in the Mongo driver
> ------------------------------------------------------------------------------
>
> Key: BEAM-6520
> URL: https://issues.apache.org/jira/browse/BEAM-6520
> Project: Beam
> Issue Type: Improvement
> Components: io-java-mongodb
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Since this seems to be now default to true and soon to be removed from the
> upstream API. We should not encourage users to configure it in MongoDbIO.
> This should be removed in a further version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
