[
https://issues.apache.org/jira/browse/BEAM-8676?focusedWorklogId=504968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504968
]
ASF GitHub Bot logged work on BEAM-8676:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/20 00:02
Start Date: 27/Oct/20 00:02
Worklog Time Spent: 10m
Work Description: veblush commented on pull request #13151:
URL: https://github.com/apache/beam/pull/13151#issuecomment-716891614
I guess `Java` test has real failures. (I don't think `Python_PVR_Flink` is
relevant to this PR)
There are two tests failing. I guess this is coming from protobuf upgrading
to 3.12 (from 3.11.1)
-
[ProtoDynamicMessageSchemaTest.testNestedRowToProto](https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/2812/testReport/junit/org.apache.beam.sdk.extensions.protobuf/ProtoDynamicMessageSchemaTest/testNestedRowToProto/)
-
[ProtoDynamicMessageSchemaTest.testMapRowToProto](https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/2812/testReport/junit/org.apache.beam.sdk.extensions.protobuf/ProtoDynamicMessageSchemaTest/testMapRowToProto/)
Because I don't think protobuf introduced actual breaking changes so I took
a look at these test
[code](https://github.com/apache/beam/blame/master/sdks/java/extensions/protobuf/src/test/java/org/apache/beam/sdk/extensions/protobuf/ProtoDynamicMessageSchemaTest.java#L202),
```
@Test
public void testNestedRowToProto() throws InvalidProtocolBufferException {
ProtoDynamicMessageSchema schemaProvider =
schemaFromDescriptor(Nested.getDescriptor());
SerializableFunction<Row, DynamicMessage> fromRow =
schemaProvider.getFromRowFunction();
// equality doesn't work between dynamic messages and other,
// so we compare string representation
assertEquals(NESTED_PROTO.toString(),
fromRow.apply(NESTED_ROW).toString());
}
```
The error message is like below.
```
org.junit.ComparisonFailure: expected:<...sted_map {
key: "k[1"
value {
primitive_double: 1.1
primitive_float: 2.2
primitive_int32: 32
primitive_int64: 64
primitive_uint32: 33
primitive_uint64: 65
primitive_sint32: 123
primitive_sint64: 124
primitive_fixed32: 30
primitive_fixed64: 62
primitive_sfixed32: 31
primitive_sfixed64: 63
primitive_bool: true
primitive_string: "horsey"
primitive_bytes: "\001\002\003\004"
}
}
nested_map {
key: "k2]"
value {
prim...> but was:<...sted_map {
key: "k[2"
value {
primitive_double: 1.1
primitive_float: 2.2
primitive_int32: 32
primitive_int64: 64
primitive_uint32: 33
primitive_uint64: 65
primitive_sint32: 123
primitive_sint64: 124
primitive_fixed32: 30
primitive_fixed64: 62
primitive_sfixed32: 31
primitive_sfixed64: 63
primitive_bool: true
primitive_string: "horsey"
primitive_bytes: "\001\002\003\004"
}
}
nested_map {
key: "k1]"
value {
prim...>
```
From the code & output reading, it might be caused by using string
comparison to compare two objects but chances are that two strings are not
normalized, which could cause them to fail. (it's my wild guess)
@alexvanboxel, @reuvenlax
I want help from original author and review on
https://github.com/apache/beam/pull/10502.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 504968)
Time Spent: 22h 10m (was: 22h)
> Beam Dependency Update Request: com.google.api:gax-grpc
> -------------------------------------------------------
>
> Key: BEAM-8676
> URL: https://issues.apache.org/jira/browse/BEAM-8676
> Project: Beam
> Issue Type: Sub-task
> Components: dependencies
> Reporter: Beam JIRA Bot
> Priority: P2
> Fix For: Not applicable, 2.20.0
>
> Time Spent: 22h 10m
> Remaining Estimate: 0h
>
> ------------------------- 2019-11-15 19:38:32.410774
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.50.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-11-19 21:03:23.809273
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.50.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-12-02 12:08:16.165687
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.50.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-12-09 12:07:17.894174
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.51.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-12-23 12:07:26.564886
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.52.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2019-12-30 14:02:53.791811
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.52.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-01-06 12:06:28.934655
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.52.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-01-13 12:06:40.087956
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.38.0. The latest version is 1.53.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-07-20 12:09:04.825811
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.57.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-07-27 12:12:54.078092
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.57.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-03 12:08:58.199365
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.57.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-10 12:07:44.203895
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-17 12:07:23.974335
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-24 12:09:28.309190
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-28 09:12:29.589564
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-28 15:49:38.274600
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-28 16:21:03.332320
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-08-31 12:10:33.064687
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-09-07 12:09:43.464093
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.54.0. The latest version is 1.58.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-10-26 12:13:35.870003
> -------------------------
> Please consider upgrading the dependency com.google.api:gax-grpc.
> The current version is 1.57.1. The latest version is 1.60.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
