[
https://issues.apache.org/jira/browse/BEAM-6513?focusedWorklogId=191271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191271
]
ASF GitHub Bot logged work on BEAM-6513:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 21:42
Start Date: 28/Jan/19 21:42
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #7636: [BEAM-6513]
Fix NPE in BeamEnumerableConverter
URL: https://github.com/apache/beam/pull/7636#discussion_r251606181
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
##########
@@ -240,7 +255,11 @@ public void startBundle(StartBundleContext context) {
public void processElement(ProcessContext context) {
Object[] avaticaRow = rowToAvatica(context.element());
if (avaticaRow.length == 1) {
- values.add(avaticaRow[0]);
+ if (avaticaRow[0] == null) {
Review comment:
I replace `Queue` with `ConcurrentLinkedQueue` now to reduce confusion.
This logical should be out of `fieldToAvatica`. Imaging we will support
Dataflow runner and then Dataflow runner does not need to handle `null` or
handle it in a different way, but Dataflow runner case `fieldToAvatica` can
just be reused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191271)
Time Spent: 2.5h (was: 2h 20m)
> BeamEnumerableConverter doest not handle Null during collecting values
> ----------------------------------------------------------------------
>
> Key: BEAM-6513
> URL: https://issues.apache.org/jira/browse/BEAM-6513
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
