[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=505933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-505933
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/20 21:52
Start Date: 28/Oct/20 21:52
Worklog Time Spent: 10m
Work Description: nehsyc commented on a change in pull request #13208:
URL: https://github.com/apache/beam/pull/13208#discussion_r513784255
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/GroupIntoBatchesOverride.java
##########
@@ -92,9 +96,58 @@ public void process(ProcessContext c) {
}
}
+ static class BatchGroupIntoBatchesWithShardedKeyOverrideFactory<K, V>
Review comment:
Two things that made me add the override for `withShardedKeys`
- We insert an explicit GBK for batch stateful dofns (although I feel this
should be done in the backend).
https://github.com/apache/beam/blob/562041956efeae2a186b1d815ea6bcd7d54682ae/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/BatchStatefulParDoOverrides.java#L228
- Currently the batch GIB doesn't use keyed states but instead partitions
the iterables after GBK:
https://github.com/apache/beam/blob/562041956efeae2a186b1d815ea6bcd7d54682ae/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/GroupIntoBatchesOverride.java#L84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 505933)
Time Spent: 8h 40m (was: 8.5h)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
