[
https://issues.apache.org/jira/browse/BEAM-10869?focusedWorklogId=506325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506325
]
ASF GitHub Bot logged work on BEAM-10869:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/20 18:10
Start Date: 29/Oct/20 18:10
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #12806:
URL: https://github.com/apache/beam/pull/12806#discussion_r514466332
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -1508,7 +1578,7 @@ public void translate(StreamingPubsubIOWrite transform,
TranslationContext conte
// Using a GlobalWindowCoder as a place holder because GlobalWindowCoder
is known coder.
stepContext.addEncodingInput(
WindowedValue.getFullCoder(VoidCoder.of(),
GlobalWindow.Coder.INSTANCE));
- stepContext.addInput(PropertyNames.PARALLEL_INPUT,
context.getInput(transform));
+ stepContext.addInput(PropertyNames.PARALLEL_INPUT, input);
Review comment:
Please refer to L1574. In java, it's not an empty string but a
serialized func, though the func is not used in portable run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 506325)
Time Spent: 14h 50m (was: 14h 40m)
> Pubsub native write should be supported over fnapi
> --------------------------------------------------
>
> Key: BEAM-10869
> URL: https://issues.apache.org/jira/browse/BEAM-10869
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Priority: P2
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
