[
https://issues.apache.org/jira/browse/BEAM-9547?focusedWorklogId=506374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506374
]
ASF GitHub Bot logged work on BEAM-9547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/20 19:58
Start Date: 29/Oct/20 19:58
Worklog Time Spent: 10m
Work Description: TheNeuralBit opened a new pull request #13224:
URL: https://github.com/apache/beam/pull/13224
This PR primarily adds an `@populate_not_implemented(pandas_type)`
annotation for use on our Deferred pandas types. It automatically populates any
missing methods and properties with `not_implemented_method`. This has a couple
of benefits:
- It's more helpful for our users, directing them to BEAM-9547, and
- It gives us a frequency count for unimplemented methods in the user guide
test:
```
4619 total test cases:
0 skipped (0.0%)
784 NotImplementedError (17.0%)
223 NameError following NotImplementedError (28.4%)
26 'resample' is not yet supported (BEAM-9547) (3.3%)
24 'rolling' is not yet supported (BEAM-9547) (3.1%)
22 'cat' is not yet supported (BEAM-9547) (2.8%)
22 'apply' is not yet supported (BEAM-9547) (2.8%)
21 'loc' is not yet supported (BEAM-9547) (2.7%)
20 'reindex' is not yet supported (BEAM-9547) (2.6%)
19 'dt' is not yet supported (BEAM-9547) (2.4%)
17 'interpolate' is not yet supported (BEAM-9547) (2.2%)
16 'sort_index' is not yet supported (BEAM-9547) (2.0%)
16 'loc.setitem' is not yet supported (BEAM-9547) (2.0%)
15 'iloc' is not yet supported (BEAM-9547) (1.9%)
13 'mean' is not yet supported (BEAM-9547) (1.7%)
13 '__getitem__' is not yet supported (BEAM-9547) (1.7%)
12 GroupBy.agg currently only supports callable arguments (1.5%)
11 'ndim' is not yet supported (BEAM-9547) (1.4%)
11 'describe' is not yet supported (BEAM-9547) (1.4%)
11 'sample' is not yet supported (BEAM-9547) (1.4%)
9 <class 'str'> (1.1%)
9 'duplicated' is not yet supported (BEAM-9547) (1.1%)
<omitted for brevity>
432 apache_beam.dataframe.frame_base.WontImplementError (9.4%)
190 NameError following
apache_beam.dataframe.frame_base.WontImplementError (44.0%)
65 order-sensitive (15.0%)
35 non-deferred (8.1%)
30 non-deferred value (6.9%)
26 order sensitive (6.0%)
22 Conversion to a non-deferred a numpy array. (5.1%)
17 non-lazy (3.9%)
16 Use iloc or loc with integer slices. (3.7%)
13 iloc.setitem (3.0%)
8 non-deferred column values (1.9%)
4 deprecated (0.9%)
3 random access files (0.7%)
1 scalar value (0.2%)
1 plot (0.2%)
1 others must be None, Series, or List[Series]. List[str] is not
supported. (0.2%)
1011 failed (21.9%)
2392 passed (51.8%)
```
The PR also includes a change to doctests.py to correctly distinguish
between NotImplemented and WontImplement when both are allowed, as well as some
minor compliance changes, in separate commits.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
| ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
| ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/)
| --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
| ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/)
<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
| [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | --- | --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 506374)
Time Spent: 30h 20m (was: 30h 10m)
> Implement all pandas operations (or raise WontImplementError)
> -------------------------------------------------------------
>
> Key: BEAM-9547
> URL: https://issues.apache.org/jira/browse/BEAM-9547
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P2
> Time Spent: 30h 20m
> Remaining Estimate: 0h
>
> We should have an implementation for every DataFrame, Series, and GroupBy
> method. Everything that's not actually implemented should get a default
> implementation that raises WontImplementError
> See https://github.com/apache/beam/pull/10757#discussion_r389132292
> Progress at the individual operation level is tracked in a
> [spreadsheet|https://docs.google.com/spreadsheets/d/1hHAaJ0n0k2tw465ORs5tfdy4Lg0DnGWIQ53cLjAhel0/edit],
> consider requesting edit access if you'd like to help out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
