[
https://issues.apache.org/jira/browse/BEAM-7386?focusedWorklogId=507294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507294
]
ASF GitHub Bot logged work on BEAM-7386:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/20 19:23
Start Date: 03/Nov/20 19:23
Worklog Time Spent: 10m
Work Description: tysonjh commented on pull request #12915:
URL: https://github.com/apache/beam/pull/12915#issuecomment-721328234
> > I am a bit confused about the usage of compareFn here. State is per key,
so I believe that your DoFn will only join items that have the same key - the
compareFn will never even get to compare items with different keys. Is the idea
to allow the user to generate a subset of an equijoin?
>
> Yes, it will be a subset of an equijoin. Sorry for the confusion.
> > I am a bit confused about the usage of compareFn here. State is per key,
so I believe that your DoFn will only join items that have the same key - the
compareFn will never even get to compare items with different keys. Is the idea
to allow the user to generate a subset of an equijoin?
>
> Yes, it will be a subset of an equijoin. Sorry for the confusion.
Now that i'm thinking about this further, the compareFn may be unnecessarily
complicating the API for this join. I imagined it would be helpful for a user
who wants to add logic before emitting a matched result, like a filter, but it
would be more idiomatic for the user to apply a filter transform to the join
result instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 507294)
Time Spent: 10h 20m (was: 10h 10m)
> Add Utility BiTemporalStreamJoin
> --------------------------------
>
> Key: BEAM-7386
> URL: https://issues.apache.org/jira/browse/BEAM-7386
> Project: Beam
> Issue Type: Improvement
> Components: sdk-ideas
> Affects Versions: 2.12.0
> Reporter: Reza ardeshir rokni
> Assignee: Tyson Hamilton
> Priority: P3
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Add utility class that enables a temporal join between two streams where
> Stream A is matched to Stream B where
> A.timestamp = (max(b.timestamp) where b.timestamp <= a.timestamp)
> This will use the following overall flow:
> KV(key, Timestamped<V>)
> | Window
> | GBK
> | Statefull DoFn
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
