[
https://issues.apache.org/jira/browse/BEAM-10940?focusedWorklogId=507354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507354
]
ASF GitHub Bot logged work on BEAM-10940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/20 22:30
Start Date: 03/Nov/20 22:30
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #13105:
URL: https://github.com/apache/beam/pull/13105#discussion_r516993287
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -502,6 +690,8 @@ public void close() throws Exception {
processWatermark1(Watermark.MAX_WATERMARK);
while (getCurrentOutputWatermark() <
Watermark.MAX_WATERMARK.getTimestamp()) {
invokeFinishBundle();
+ // Sleep for 5s to wait for any timer to be fired.
+ Thread.sleep(5000);
Review comment:
This was not a bug before we support sdf initiate checkpoint because
normal processing time timer doesn't hold watermark. Now we are setting
processing time timer to reschedule sdf residuals which holds the watermark
back. When entering `ExecutableStageDoFnOperator.close()`, we will always in
the while loop until all sdf processing timers get fired and watermark holds
are removed. So the comment ` // Sleep for 5s to wait for any timer to be
fired.` is not precise. The comment should be ` // Sleep for 5s to wait for any
SDF timer to be fired.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 507354)
Time Spent: 9h 40m (was: 9.5h)
> Portable Flink runner should handle DelayedBundleApplication from
> ProcessBundleResponse.
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-10940
> URL: https://issues.apache.org/jira/browse/BEAM-10940
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: P2
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
> SDF can produce residuals by self-checkpoint, which will be returned to
> runner by ProcessBundleResponse.DelayedBundleApplication. The portable runner
> should be able to handle the DelayedBundleApplication and reschedule it based
> on the timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
