[
https://issues.apache.org/jira/browse/BEAM-10556?focusedWorklogId=507708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507708
]
ASF GitHub Bot logged work on BEAM-10556:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/20 18:17
Start Date: 04/Nov/20 18:17
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#13261:
URL: https://github.com/apache/beam/pull/13261#discussion_r517539463
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -22,7 +22,7 @@ plugins { id 'org.apache.beam.module' }
applyJavaNature(
automaticModuleName: 'org.apache.beam.runners.dataflow',
enableChecker: false,
- ignoreRawtypeErrors: true)
+ )
Review comment:
Ideally, spotless would reformat this, but I guess it doesn't.
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/cookbook/TriggerExample.java
##########
@@ -121,7 +121,9 @@
* <p>The example will try to cancel the pipelines on the signal to terminate
the process (CTRL-C)
* and then exits.
*/
-@SuppressWarnings("nullness") //
TODO(https://issues.apache.org/jira/browse/BEAM-10402)
+@SuppressWarnings({
+ "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
Review comment:
There are a number of changes like this that I did just to make it more
sane to automatically add the rawtype warnings. I can revert if you like or
separate into another commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 507708)
Time Spent: 4h (was: 3h 50m)
> Eliminate rawtype errors from Beam Java
> ---------------------------------------
>
> Key: BEAM-10556
> URL: https://issues.apache.org/jira/browse/BEAM-10556
> Project: Beam
> Issue Type: Improvement
> Components: io-java-amqp, io-java-avro, io-java-aws, io-java-azure,
> io-java-cassandra, io-java-clickhouse, io-java-elasticsearch, io-java-files,
> io-java-gcp, io-java-hadoop-file-system, io-java-hadoop-format,
> io-java-hbase, io-java-hcatalog, io-java-jdbc, io-java-jms, io-java-kafka,
> io-java-kinesis, io-java-kudu, io-java-mongodb, io-java-mqtt,
> io-java-parquet, io-java-rabbitmq, io-java-redis, io-java-solr, io-java-text,
> io-java-tfrecord, io-java-tika, io-java-utilities, io-java-xml,
> sdk-java-core, sdk-java-harness
> Reporter: Kenneth Knowles
> Priority: P3
> Labels: Clarified, starter
> Time Spent: 4h
> Remaining Estimate: 0h
>
> A few modules used to have no rawtype errors. Now many of them do. Rawtypes
> are a legacy compatibility feature that should not be used in new code.
> Concretely, they obscure types (readability), mask errors (casts failing at
> runtime), and harm static analysis (checker framework recommends eliminating
> rawtypes as your first step)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
