[
https://issues.apache.org/jira/browse/BEAM-11146?focusedWorklogId=508108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508108
]
ASF GitHub Bot logged work on BEAM-11146:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/20 12:09
Start Date: 05/Nov/20 12:09
Worklog Time Spent: 10m
Work Description: je-ik commented on pull request #13240:
URL: https://github.com/apache/beam/pull/13240#issuecomment-722338502
If we have reasons to believe, that reusing the `objectReuse` could result
in breaking existing pipelines (which I think is low probability, but is
admittedly non-zero), I'd suggest the following:
- deprecate `objectReuse`
- introduce `usingImmutableTypes` (or similar), which would have the
meaning of both `objectReuse` and `fasterCopy`
- remove `fasterCopy` and use only `usingImmutableTypes` in place of it
Using of `objectReuse` would result in deprecation warning, suggesting to
validate pipeline against DirectRunner with immutability enforced and then to
enable `usingImmutableTypes`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 508108)
Time Spent: 2h 20m (was: 2h 10m)
> Add option to disable copying between Flink runner
> ---------------------------------------------------
>
> Key: BEAM-11146
> URL: https://issues.apache.org/jira/browse/BEAM-11146
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Teodor Spæren
> Assignee: Teodor Spæren
> Priority: P2
> Labels: performance
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> In order to implement Flink
> [TypeSerializer|https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializer.java]
> the runner implements
> [CoderTypeSerializer|https://github.com/apache/beam/blob/master/runners/flink/1.8/src/main/java/org/apache/beam/runners/flink/translation/types/CoderTypeSerializer.java#L84].
> The way the {{copy}} function is implemented is by first serializing and
> then deserializing each element. This means that such a deep copy needs to be
> done between each operator and this can become a bottleneck.
> The reason the {{copy}} functions need to be implemented is that Flink
> guarantees that elements will be deep copied between each operator. In Beam
> this is the users responsibility and so this is not strictly neccecarry.
> The aim of this improvement is to introduce an option on the Flink Runner,
> that eliminates this overhead, by simply returning the value.
> [Here is the mailing list
> discussion|https://lists.apache.org/thread.html/r24129dba98782e1cf4d18ec738ab9714dceb05ac23f13adfac5baad1%40%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
