[
https://issues.apache.org/jira/browse/BEAM-6302?focusedWorklogId=191707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191707
]
ASF GitHub Bot logged work on BEAM-6302:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/19 14:42
Start Date: 29/Jan/19 14:42
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7662: [BEAM-6302]
Allow setting Compression Codec in ParquetIO
URL: https://github.com/apache/beam/pull/7662#discussion_r251860700
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -262,19 +264,36 @@ public static Sink sink(Schema schema) {
@Nullable
abstract String getJsonSchema();
+ @Nullable
+ abstract CompressionCodecName getCompressionCodec();
+
+ abstract Builder toBuilder();
+
@AutoValue.Builder
abstract static class Builder {
abstract Builder setJsonSchema(String jsonSchema);
+ abstract Builder setCompressionCodec(CompressionCodecName
compressionCodec);
+
abstract Sink build();
}
+ /** Specifies compression codec. By default,
CompressionCodecName.UNCOMPRESSED. */
Review comment:
The default should be probably SNAPPY to be consistent with AvroIO (as
discussed in slack).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191707)
Time Spent: 50m (was: 40m)
> Allow setting compression codec in ParquetIO write
> --------------------------------------------------
>
> Key: BEAM-6302
> URL: https://issues.apache.org/jira/browse/BEAM-6302
> Project: Beam
> Issue Type: Improvement
> Components: io-java-parquet
> Reporter: Lukasz Gajowy
> Assignee: Lukasz Gajowy
> Priority: Critical
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This is not possible now disallowing users to write compressed files.
> AvroParquetWriter setting the codec using
> [withCompressionCodec()|https://github.com/apache/parquet-mr/blob/1e0760a1f9c138e3cb66143f1c9fdf8ee2e8eef7/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L401]
> method should be enough to solve this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
