[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=508548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508548
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/20 17:54
Start Date: 06/Nov/20 17:54
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #13208:
URL: https://github.com/apache/beam/pull/13208#discussion_r518911465
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/GroupIntoBatchesOverride.java
##########
@@ -210,20 +211,23 @@ public StreamingGroupIntoBatchesWithShardedKey(
}
}
- private static <K, V> PCollection<KV<ShardedKey<K>, V>>
ShardKeys(PCollection<KV<K, V>> input) {
+ private static <K, V> PCollection<KV<ShardedKey<K>, V>>
shardKeys(PCollection<KV<K, V>> input) {
KvCoder<K, V> inputCoder = (KvCoder<K, V>) input.getCoder();
org.apache.beam.sdk.coders.Coder<K> keyCoder =
(org.apache.beam.sdk.coders.Coder<K>)
inputCoder.getCoderArguments().get(0);
org.apache.beam.sdk.coders.Coder<V> valueCoder =
(org.apache.beam.sdk.coders.Coder<V>)
inputCoder.getCoderArguments().get(1);
return input
.apply(
- "ShardKeys",
+ "Shard Keys",
MapElements.via(
new SimpleFunction<KV<K, V>, KV<ShardedKey<K>, V>>() {
@Override
public KV<ShardedKey<K>, V> apply(KV<K, V> input) {
- return KV.of(ShardedKey.of(input.getKey(), new byte[0]),
input.getValue());
+ long tid = Thread.currentThread().getId();
Review comment:
I meant you could have a static-level long created by java.util.UUID or
similar, plus the thread id queried here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 508548)
Time Spent: 10h 20m (was: 10h 10m)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
