[
https://issues.apache.org/jira/browse/BEAM-11194?focusedWorklogId=508635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508635
]
ASF GitHub Bot logged work on BEAM-11194:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/20 22:07
Start Date: 06/Nov/20 22:07
Worklog Time Spent: 10m
Work Description: kw2542 commented on a change in pull request #13280:
URL: https://github.com/apache/beam/pull/13280#discussion_r519029536
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/KeyedTimerData.java
##########
@@ -192,7 +193,10 @@ public void encode(KeyedTimerData<K> value, OutputStream
outStream)
keyBytes = baos.toByteArray();
}
- return new KeyedTimerData(keyBytes, key, timer);
+ final String timerFamilyId = inStream.available() > 0 ?
STRING_CODER.decode(inStream) : "";
Review comment:
I will add the comment when moving the recently added outputTimestamps
field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 508635)
Time Spent: 0.5h (was: 20m)
> Add timer family id support in KeyedTimerData
> ---------------------------------------------
>
> Key: BEAM-11194
> URL: https://issues.apache.org/jira/browse/BEAM-11194
> Project: Beam
> Issue Type: Task
> Components: runner-samza
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Timer family id is not being encoded in KeyedTimerDataCoder, which means
> Samza cannot use this feature at all.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
