[
https://issues.apache.org/jira/browse/BEAM-11188?focusedWorklogId=508662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508662
]
ASF GitHub Bot logged work on BEAM-11188:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/20 00:10
Start Date: 07/Nov/20 00:10
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #13255:
URL: https://github.com/apache/beam/pull/13255#issuecomment-723354730
I worked around the scope problem by essentially removing any composite
transforms from the proto representation of the external transform, before
continuing on with the existing logic. I spent a while trying to more properly
fix it so it would work with the composite transform in there, but it seems
like there are many places in the existing logic where composites weren't
accounted for, and at the end of the day I don't think there's anything gained
at the moment by changing the logic to work with the composite in there.
@lostluck let me know what you think. Any issues we might hit with this
workaround in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 508662)
Time Spent: 40m (was: 0.5h)
> Go Cross-Language UX polish and refactoring
> -------------------------------------------
>
> Key: BEAM-11188
> URL: https://issues.apache.org/jira/browse/BEAM-11188
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is a bug for progress on various small usability and UX improvements to
> the Go SDK implementation of Cross-Language. I don't feel each one
> individually is important enough for a Jira, but together it's worth
> recording progress.
> Tasks included:
> * Adjust user-facing XLang functions so that Sink and Source versions are
> actually sinks and sources (no outputs and no inputs respectively).
> * Rename SourceInputTag and SinkOutputTag since they are no longer used with
> source/sink versions of the methods.
> * Adjust beam/xlang.go so that it doesn't need to import job_management
> protos. Move the proto creation down into the method the proto is passed to
> (which is xlangx.Expand).
> * Refactor the functions in xlangx/translate.go and how they are used, since
> right now the functions just get called one after another in sequence.
> * Move as many xlang calls out of universal.go as possible. They should be
> handled as part of the normal sequence of the SDK, such as in proto
> marshalling and unmarshalling.
> * Add wrappers around xlang calls in existing examples, to both give a
> cleaner interface and provide an example of how xlang transforms should be
> implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
