[
https://issues.apache.org/jira/browse/BEAM-11192?focusedWorklogId=509268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-509268
]
ASF GitHub Bot logged work on BEAM-11192:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/20 17:33
Start Date: 09/Nov/20 17:33
Worklog Time Spent: 10m
Work Description: tysonjh commented on pull request #13260:
URL: https://github.com/apache/beam/pull/13260#issuecomment-724161814
> > > Ah, I hit send before finishing my sentence: Having misc. Dataflow
integration tests bundled with other service integration tests obscures what
was tested and conflates quite a few unrelated things, plus "Java PostCommit"
is mostly uninformative name. If we don't have a strong reason reason to bundle
these (like efficiency or UI limitations), we should move to unbundle them.
> >
> >
> > Agreed. It is also wasteful to rerun by phrase on the monolith task when
only a subset of the tasks failed. We can start in this PR by not adding the
task to the PostCommit, then in a separate PR teasing out the others with their
own groovy configs (if they don't already have them).
> > It is probably worth reviewing all the pre/post/cron jobs towards
achieving a sane strategy and potentially documenting a process or philosophy
for adding new ones. The benefit would be more focused testing (i.e. less flake
potential), faster builds, lower infra costs, maybe even identifying some gaps
or redundancies. Started by creating
https://issues.apache.org/jira/browse/BEAM-11197
>
> I'm going to add a new postcommit config for each of the following. Do you
agree this is a step in the right direction? @kennknowles @boyuanzz
>
> dependsOn googleCloudPlatformRunnerV2IntegrationTest
> dependsOn examplesJavaRunnerV2IntegrationTest
> dependsOn coreSDKJavaRunnerV2IntegrationTest
I've added the `examplesJavaRunnerV2IntegrationTest` postcommit for now
since it is the only one running for the legacy runner in postcommit. We can
continue the discussion in BEAM-11197, I need to do some research on how
Jenkins schedules jobs, and our current testing strategy but I don't have time
right now so let's at least match what exists today for the legacy runner tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 509268)
Time Spent: 3.5h (was: 3h 20m)
> Repurpose google-cloud-dataflow-java FnApi tasks for Runner V2
> --------------------------------------------------------------
>
> Key: BEAM-11192
> URL: https://issues.apache.org/jira/browse/BEAM-11192
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Tyson Hamilton
> Assignee: Tyson Hamilton
> Priority: P2
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> The Java FnApi test tasks are not in use for CI so they should be removed. At
> the same time, Dataflow Runner V2 needs similar test tasks. Refactor the
> FnApi test tasks in google-cloud-dataflow-java build.gradle to use runner v2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
