[ 
https://issues.apache.org/jira/browse/BEAM-11207?focusedWorklogId=509319&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-509319
 ]

ASF GitHub Bot logged work on BEAM-11207:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Nov/20 19:36
            Start Date: 09/Nov/20 19:36
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on a change in pull request #13272:
URL: https://github.com/apache/beam/pull/13272#discussion_r520070443



##########
File path: sdks/go/pkg/beam/core/monitoring/monitoring.go
##########
@@ -13,10 +13,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-package harness
+package monitoring

Review comment:
       That said, doing the inverse: Having the new metricx package have 
Exported payload encoding helpers, and have the harness specific monitoring 
code depend on those, would be a good move, if you don't like the copying.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 509319)
    Time Spent: 40m  (was: 0.5h)

> [Go SDK] Support metrics querying
> ---------------------------------
>
>                 Key: BEAM-11207
>                 URL: https://issues.apache.org/jira/browse/BEAM-11207
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-go
>            Reporter: Kamil Wasilewski
>            Assignee: Kamil Wasilewski
>            Priority: P2
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Design doc: [https://s.apache.org/get-metrics-api]
> Go SDK does not offer a way to query a pipeline's metrics. Go SDK needs to 
> implement a code that would call the GetJobMetrics RPC and let users query 
> the result by using an API similar to existing APIs in Python and Java SDKs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to