[
https://issues.apache.org/jira/browse/BEAM-11073?focusedWorklogId=510975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510975
]
ASF GitHub Bot logged work on BEAM-11073:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/20 18:40
Start Date: 12/Nov/20 18:40
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #13137:
URL: https://github.com/apache/beam/pull/13137#discussion_r522331585
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/DicomIOReadIT.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.healthcare;
+
+import static
org.apache.beam.sdk.io.gcp.healthcare.HL7v2IOTestUtil.HEALTHCARE_DATASET_TEMPLATE;
+
+import java.io.IOException;
+import org.apache.beam.sdk.PipelineResult;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+@SuppressWarnings({"nullness", "rawtypes", "uninitialized"})
+public class DicomIOReadIT {
+ @Rule public transient TestPipeline pipeline = TestPipeline.create();
+
+ private String healthcareDataset;
+ private String project;
+ private HealthcareApiClient client;
+ private String storeName = "foo";
+
+ @Before
+ public void setup() throws IOException {
+ project =
+ TestPipeline.testingPipelineOptions()
+ .as(HealthcareStoreTestPipelineOptions.class)
+ .getStoreProjectId();
+ healthcareDataset = String.format(HEALTHCARE_DATASET_TEMPLATE, project);
+ client = new HttpHealthcareApiClient();
+
+ client.createDicomStore(healthcareDataset, storeName);
+ }
+
+ @After
+ public void deleteDicomStore() throws IOException {
+ client.deleteDicomStore(healthcareDataset + "/dicomStores/" + storeName);
+ }
+
+ @Test
+ public void testDicomMetadataRead() throws IOException {
+ String webPath =
+ String.format("%s/dicomStores/%s/dicomWeb/studies/",
healthcareDataset, storeName);
+
+ DicomIO.ReadStudyMetadata.Result result =
+ pipeline.apply(Create.of(webPath)).apply(DicomIO.readStudyMetadata());
Review comment:
can you add a PAssert verification here? To verify that the expected
message shows up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 510975)
Time Spent: 5h 50m (was: 5h 40m)
> GCP HCLS Api - Dicom IO Connector for Java
> ------------------------------------------
>
> Key: BEAM-11073
> URL: https://issues.apache.org/jira/browse/BEAM-11073
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Aliraza Nagamia
> Assignee: Aliraza Nagamia
> Priority: P2
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> We are looking to create a new Java Pipeline Connector to help facilitate
> Reading data from the Imaging API in GCP. Initially, this connector will be
> used to read study level metadata of Dicom instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
