[ 
https://issues.apache.org/jira/browse/BEAM-11211?focusedWorklogId=511458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-511458
 ]

ASF GitHub Bot logged work on BEAM-11211:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Nov/20 17:39
            Start Date: 13/Nov/20 17:39
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on a change in pull request 
#13302:
URL: https://github.com/apache/beam/pull/13302#discussion_r523117790



##########
File path: sdks/python/apache_beam/io/parquetio.py
##########
@@ -506,6 +509,11 @@ def __init__(
         compression_type=CompressionTypes.UNCOMPRESSED)
     self._schema = schema
     self._codec = codec
+    if ARROW_MAJOR_VERSION == 1 and self._codec.lower() == "lz4":

Review comment:
       I convert the version string with `int` above




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 511458)
    Time Spent: 40m  (was: 0.5h)

> Support multiple major pyarrow versions
> ---------------------------------------
>
>                 Key: BEAM-11211
>                 URL: https://issues.apache.org/jira/browse/BEAM-11211
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: P2
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should support using ParquetIO with multiple pyarrow versions, up to 2.x.
> Specific actions:
> - Change pyarrow requirement from >=0.15.1,<0.18.0 to >=0.15.1,<3.0.0
> - There's a limitation in 1.x where it can't write LZ4 compression, we should 
> catch attempts to do this at construction time and raise a useful error (See 
> ARROW-9424).
> - Add the ability to test with different pyarrow versions and run in 
> PostCommit to verify.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to