[
https://issues.apache.org/jira/browse/BEAM-9650?focusedWorklogId=514927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514927
]
ASF GitHub Bot logged work on BEAM-9650:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/20 23:55
Start Date: 20/Nov/20 23:55
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #13170:
URL: https://github.com/apache/beam/pull/13170#discussion_r528030049
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1931,3 +1903,132 @@ def file_path_to_remove(unused_elm):
*self._args,
**self._kwargs))
| _PassThroughThenCleanup(files_to_remove_pcoll))
+
+
+class ReadFromBigQueryRequest:
+ """
+ Class that defines data to read from BQ.
+ """
+ def __init__(
+ self,
+ query: str = None,
+ use_standard_sql: bool = True,
Review comment:
args are split between the read request and the transform. I would say
all args exist in either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 514927)
Time Spent: 19h 40m (was: 19.5h)
> Add consistent slowly changing side inputs support
> --------------------------------------------------
>
> Key: BEAM-9650
> URL: https://issues.apache.org/jira/browse/BEAM-9650
> Project: Beam
> Issue Type: Bug
> Components: io-ideas
> Reporter: Mikhail Gryzykhin
> Assignee: Pablo Estrada
> Priority: P3
> Time Spent: 19h 40m
> Remaining Estimate: 0h
>
> Add implementation for slowly changing dimentions based on [design
> doc](https://docs.google.com/document/d/1LDY_CtsOJ8Y_zNv1QtkP6AGFrtzkj1q5EW_gSChOIvg/edit]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)