[
https://issues.apache.org/jira/browse/BEAM-11182?focusedWorklogId=515845&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515845
]
ASF GitHub Bot logged work on BEAM-11182:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/20 00:41
Start Date: 24/Nov/20 00:41
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13406:
URL: https://github.com/apache/beam/pull/13406#discussion_r529086949
##########
File path: website/www/site/i18n/home/calendar/en.yaml
##########
@@ -0,0 +1,42 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- id: home-calendar-title
+ translation: "Stay up to date with Beam"
+- id: home-calendar-category-tag-first
+ translation: "Category"
+- id: home-calendar-category-date-first
+ translation: "2020/02/21"
+- id: home-calendar-card-title-first
+ translation: "Performance-Driven Runtime Type Checking for the Python SDK"
+- id: home-calendar-card-author-first
+ translation: "Saavan Nanavati"
+- id: home-calendar-category-tag-second
+ translation: "Category"
+- id: home-calendar-category-date-second
+ translation: "2020/02/21"
+- id: home-calendar-card-title-second
+ translation: "Performance-Driven Runtime Type Checking for the Python SDK"
+- id: home-calendar-card-author-second
+ translation: "Saavan Nanavati"
+- id: home-calendar-category-tag-third
+ translation: "Category"
+- id: home-calendar-category-date-third
+ translation: "2020/02/21"
+- id: home-calendar-card-title-third
+ translation: "Performance-Driven Runtime Type Checking for the Python SDK"
+- id: home-calendar-card-author-third
+ translation: "Saavan Nanavati"
+- id: home-calendar-card-events-title
+ translation: "Upcoming events"
+- id: home-calendar-card-events-button
+ translation: "SEE MORE"
Review comment:
What is the difference between files like this (`i18n/**/en.yaml`), and
the miscellaneous `en` directories in `data`? AFAICT the difference is just
that i18n just has simpler id - translation while the config in data can be
more complex and structured.
Based on that distinction it seems like much of this would be more
appropriate in `data`
##########
File path: website/www/site/i18n/home/calendar/en.yaml
##########
@@ -0,0 +1,42 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- id: home-calendar-title
+ translation: "Stay up to date with Beam"
+- id: home-calendar-category-tag-first
+ translation: "Category"
+- id: home-calendar-category-date-first
+ translation: "2020/02/21"
+- id: home-calendar-card-title-first
+ translation: "Performance-Driven Runtime Type Checking for the Python SDK"
Review comment:
In the future, will this data be pulled from recent blog posts, or will
we have to keep it up to date?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 515845)
Remaining Estimate: 0h
Time Spent: 10m
> [Website revamp] Development of Stay up to date component
> ---------------------------------------------------------
>
> Key: BEAM-11182
> URL: https://issues.apache.org/jira/browse/BEAM-11182
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Agnieszka Sell
> Assignee: Nam Bui
> Priority: P2
> Labels: website-revamp-2020, website-revamp-sprint-5
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
