[ 
https://issues.apache.org/jira/browse/BEAM-11327?focusedWorklogId=516019&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-516019
 ]

ASF GitHub Bot logged work on BEAM-11327:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Nov/20 10:36
            Start Date: 24/Nov/20 10:36
    Worklog Time Spent: 10m 
      Work Description: nielsbasjes commented on pull request #13410:
URL: https://github.com/apache/beam/pull/13410#issuecomment-732811394


   A few weeks ago a colleague of mine mentioned he ran into a character 
encoding issue when building a Beam application.
   I just spoke him and he pointed me to this comment that simply documents 
what he ran into: 
https://github.com/apache/beam/blob/master/sdks/java/io/xml/src/main/java/org/apache/beam/sdk/io/xml/XmlSource.java#L335
   ```
   // We use Woodstox because the StAX implementation provided by OpenJDK 
reports
   // character locations incorrectly. Note that Woodstox still currently 
reports *byte*
   // locations incorrectly when parsing documents that contain multi-byte 
characters.
   ```
   Apparently even with this fix in place the project as a whole still has 
character encoding problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 516019)
    Time Spent: 50m  (was: 40m)

> Replace Charset.defaultCharset() with StandardCharsets.UTF_8
> ------------------------------------------------------------
>
>                 Key: BEAM-11327
>                 URL: https://issues.apache.org/jira/browse/BEAM-11327
>             Project: Beam
>          Issue Type: Bug
>          Components: test-failures
>            Reporter: Omar Ismail
>            Assignee: Omar Ismail
>            Priority: P2
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> When running tests where `getBytes(Charset.defaultCharset())` is called, and 
> `locale` is not set to "UTF8", the test fails.
>  
> I am going to replace all mentions of `Charset.defaultCharset()` to 
> `StandardCharsets.UTF_8` so testing is not affected my computer settings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to