[
https://issues.apache.org/jira/browse/BEAM-10278?focusedWorklogId=516471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-516471
]
ASF GitHub Bot logged work on BEAM-10278:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/20 04:25
Start Date: 25/Nov/20 04:25
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #13419:
URL: https://github.com/apache/beam/pull/13419#issuecomment-733455263
> > It looks like the root cause is that we don't have python build.gradle
in google3. I'm trying to skip createCrossLanguageValidatesRunnerTask if
:sdks:python subproject doesn't exist. It's okay since we don't use that task
in google3.
>
> That would probably work, but I'm not sure it's the best solution. I
prefer moving the tests to `dataflow/common.gradle` because that way all of the
tests that depend on both the Dataflow runner and Python are in the same place.
I see. Please note that `createCrossLanguageValidatesRunnerTask` creates not
only the python tests but also java tests. When we put
`createCrossLanguageValidatesRunnerTask` in the build file, it creates four
variants of xlang tests:
- Java pipeline using Python external transforms
- Java pipeline using Java external transforms
- Python pipeline using Python external transforms
- Python pipeline using Java external transforms
It's not totally impossible but it may look awkward to launch Java pipelines
using Java external transforms from python:test-suites module.
>
> Also note that `dataflow/common.gradle` already transitively depends on
the Java SDK, so this PR is only removing dependencies through consolidation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 516471)
Time Spent: 2.5h (was: 2h 20m)
> Remove Python-dependent tasks from runner modules
> -------------------------------------------------
>
> Key: BEAM-10278
> URL: https://issues.apache.org/jira/browse/BEAM-10278
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink, runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The Flink and Spark runner modules should only have Java dependencies. Tests
> relying on Python should be moved elsewhere.
> https://github.com/apache/beam/blob/fe7ae26d281d0f74577c3559eb916f36816f238f/runners/spark/job-server/build.gradle#L138
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
