[
https://issues.apache.org/jira/browse/BEAM-11354?focusedWorklogId=516869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-516869
]
ASF GitHub Bot logged work on BEAM-11354:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/20 00:28
Start Date: 26/Nov/20 00:28
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #13431:
URL: https://github.com/apache/beam/pull/13431#issuecomment-734006158
Yes, this is more similar to Java. Good point about doing this for the
watermark provider too--I'll do that. (Removing the old way would be
backwards incompatible and a more invasive change.)
On Wed, Nov 25, 2020 at 4:20 PM Boyuan Zhang <[email protected]>
wrote:
> It seems like we want to do the similar thing to java? Java SDK uses DoFn
> as both RestrictionProvider and WatemarkEstimatorProvider. If so, it
> would be better for python sdk to either do the same thing as java sdk or
> keep using RestrictionTracker and WatermarkEstimatorProvider classes.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/13431#issuecomment-734004182>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AADWVAJXBI64PMALKQCNTF3SRWNORANCNFSM4UDA4RDQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 516869)
Time Spent: 50m (was: 40m)
> Allow Splittable DoFn itself to be used as the restriction provider.
> ---------------------------------------------------------------------
>
> Key: BEAM-11354
> URL: https://issues.apache.org/jira/browse/BEAM-11354
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Binding the provider to the DoFn class itself at construction time can be
> limiting, we should add an option to use the DoFn instance itself as the
> restriction provider.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
